Uh oh!
There was an error while loading. Please reload this page.
Fix "fileActions.currentFile" not set before using it - #7624
Merged
MorrisJobke merged 1 commit intoJan 2, 2018
Conversation
When an empty area of a file row was clicked and the "Details" action was executed "fileActions.currentFile" was not guaranteed to be set to the appropriate object (it depended on the previous actions of the user), so when it was used by "getCurrentMimeType()" and other FileActions functions they may not work as expected. Now it is explicitly set to the appropriate value before its use. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Codecov Report
@@ Coverage Diff @@## master #7624 +/- ##
============================================
+ Coverage 51.17% 51.17% +<.01%
Complexity 24886 24886 ============================================
Files 1602 1602 Lines 94750 94750 Branches 1368 1368 ============================================
+ Hits 48485 48486 +1 + Misses 46265 46264 -1
|
rullzer
approved these changes
Dec 28, 2017
MorrisJobke
approved these changes
Jan 2, 2018
MorrisJobke
deleted the
fix-fileActions-currentFile-not-set-before-using-it
branch
January 2, 2018 09:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fix for the second commit of #7591
When an empty area of a file row was clicked and the Details action was executed
fileActions.currentFilewas not guaranteed to be set to the appropriate object (it depended on the previous actions of the user), so when it was used bygetCurrentMimeType()and other FileActions functions they may not work as expected. Now it is explicitly set to the appropriate value before its use.