Uh oh!
There was an error while loading. Please reload this page.
Fix scss webroot and url rewrite - #7631
Merged
Merged
Conversation
skjnldsvforce-pushed
the
fix-scss-webroot-and-url-rewrite
branch
from
December 27, 2017 10:05
835f6fa to
24a30fcCompareCodecov Report
@@ Coverage Diff @@## master #7631 +/- ##
============================================
+ Coverage 51.17% 51.18% +0.01% - Complexity 24886 24889 +3
============================================
Files 1602 1602 Lines 94752 94798 +46 Branches 1368 1368 ============================================
+ Hits 48486 48522 +36 - Misses 46266 46276 +10
|
skjnldsvforce-pushed
the
fix-scss-webroot-and-url-rewrite
branch
4 times, most recently
from
December 28, 2017 09:09
1d9da6c to
5a9d097Compareskjnldsvforce-pushed
the
fix-scss-webroot-and-url-rewrite
branch
16 times, most recently
from
December 29, 2017 06:37
e5bb608 to
c732f56Compareskjnldsv
commented
Dec 29, 2017
MemberAuthor
Test finally fixed! :) @zauguin please test! 😃 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Fixed tests Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
- With root installation - Core css - App inside server root - Secondary apps directory outside server root - With an installation in a sub directory - Core css - App inside server root - Secondary apps directory outside server root Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
fix-scss-webroot-and-url-rewrite
branch
from
December 30, 2017 04:56
c732f56 to
c0c4443Comparejuliusknorr
approved these changes
Jan 2, 2018
zauguin
commented
Jan 2, 2018
Works fine. Awesome👍 |
skjnldsv
commented
Jan 3, 2018
MemberAuthor
We need a backport imho :) |
MorrisJobke
commented
Jan 3, 2018
Member
@skjnldsv Do it ;) |
karlitschek
commented
Jan 3, 2018
Member
Backport is fine. Please note that this change has the potential to break in esoteric/non standard webserver setups. So good testing is important. |
skjnldsv
commented
Jan 3, 2018
MemberAuthor
@karlitschek that's why I added tests with various installation instances to make sure it doesn't break. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#7534
Also fixes the following situations:
➡️ Fix the massiv log spamming of not finding the webroot
TODO: