Skip to content

Fixes actions on a mounted storage - #7638

Closed
amkad wants to merge 1 commit into
nextcloud:masterfrom
amkad:bug-7437
Closed

Fixes actions on a mounted storage#7638
amkad wants to merge 1 commit into
nextcloud:masterfrom
amkad:bug-7437

Conversation

@amkad

Copy link
Copy Markdown

Fixes#7437 that looks like a regress after introducing the selection column.

Unfortunately, I do not know the project well enough to create from scratch a test for statusmanager.js

Signed-off-by: Alexey Kaigorodov <amkad@mail.ru>
@rullzer

Copy link
Copy Markdown
Member

Again awesome work @amkad feel free to also join #nextcloud-dev on freenode!

@danxuliu can you have a look?

@rullzerrullzer added this to the Nextcloud 13 milestone Dec 29, 2017
@rullzerrullzer added 3. to review Waiting for reviews high labels Dec 29, 2017
@danxuliu

Copy link
Copy Markdown
Member

@amkad Thanks for your contribution!

I had already fixed this a few days ago, but I did not create the pull request 🤦 Sorry!

I have created it now because it includes some additional fixes too (the icon and the External storages file list layout): #7658 Due to those additional fixes I hope that you do not mind if I close this one :-)

@danxuliudanxuliu closed this Jan 2, 2018
@amkad

amkad commented Jan 2, 2018

Copy link
Copy Markdown
Author

@danxuliu No worries! I'll be glad to see this change in the master.

@amkad
amkad deleted the bug-7437 branch January 3, 2018 18:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewshigh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@amkad@rullzer@danxuliu