Skip to content

Show max warning comment lenth again - #7648

Merged
rullzer merged 1 commit into
masterfrom
fix_7414
Jan 2, 2018
Merged

Show max warning comment lenth again#7648
rullzer merged 1 commit into
masterfrom
fix_7414

Conversation

@rullzer

Copy link
Copy Markdown
Member

Fixes#7414

Since we no longer use an input field we have to use text instead of
val.

I basically just followed the debug session written down by @danxuliu in #7414 :)

@danxuliudanxuliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #7414 the length should be tested against the plain text mentions instead of the rich text ones, but if you prefer to fix that in a different pull request (and the other silently failing unit tests ;-) ) fine by me ;-)

@rullzer

Copy link
Copy Markdown
MemberAuthor

@danxuliu if you are up for it feel free to push commits here ;)

@MorrisJobke

Copy link
Copy Markdown
Member

As mentioned in #7414 the length should be tested against the plain text mentions instead of the rich text ones, but if you prefer to fix that in a different pull request (and the other silently failing unit tests ;-) ) fine by me ;-)

Let's do this in a separate PR and merge after the restarted CI job finished: https://drone.nextcloud.com/nextcloud/server/3597

Fixes#7414
Since we no longer use an input field we have to use text instead of
val.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov

codecovBot commented Jan 2, 2018

Copy link
Copy Markdown

Codecov Report

Merging #7648 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## master #7648 +/- ##
=========================================
Coverage 51.17% 51.17% Complexity 24886 24886 =========================================
Files 1602 1602 Lines 94752 94752 Branches 1368 1368 =========================================
Hits 48486 48486 Misses 46266 46266
Impacted FilesCoverage ΔComplexity Δ
apps/comments/js/commentstabview.js84.16% <100%> (ø)0 <0> (ø)⬇️
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)
lib/private/Server.php81.43% <0%> (-0.12%)134% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️
lib/private/Security/CertificateManager.php92.07% <0%> (+0.99%)39% <0%> (ø)⬇️

@rullzer
rullzer merged commit d9419f3 into masterJan 2, 2018
@rullzer
rullzer deleted the fix_7414 branch January 2, 2018 10:11
@MorrisJobkeMorrisJobke mentioned this pull request Jan 2, 2018
30 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@rullzer@MorrisJobke@ChristophWurst@blizzz@danxuliu