Uh oh!
There was an error while loading. Please reload this page.
throw ServerNotAvailableException when LDAP is caught shutting down - #7662
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Codecov Report
@@ Coverage Diff @@## master #7662 +/- ##
============================================
- Coverage 51.17% 51.17% -0.01% - Complexity 24885 24886 +1
============================================
Files 1601 1601 Lines 94746 94749 +3 Branches 1368 1368 ============================================
Hits 48486 48486 - Misses 46260 46263 +3
|
MorrisJobke
approved these changes
Jan 2, 2018
rullzer
approved these changes
Jan 2, 2018
rullzer
left a comment
Member
There was a problem hiding this comment.
Fine by me.
But yes lets go for whitelisting as well!
blizzz
commented
Jan 3, 2018
MemberAuthor
ty. opened a ticket for 14 #7675 |
This was referenced Jan 5, 2018
blizzz
commented
Jan 5, 2018
MemberAuthor
backports done ^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen on our instance. Otherwise, processing just continues and who knows what happens.
In general it's probably a better idea to throw exceptions by default and only let successes and other acceptable codes pass. Whitelisting, basically. Would be a separate PR though.
@nextcloud/ldap