Uh oh!
There was an error while loading. Please reload this page.
[stable12] Fix drag shadow not visible when dragging a file on a narrow screen - #7666
Merged
MorrisJobke merged 1 commit intoJan 9, 2018
Conversation
When a file from the file list is dragged a drag shadow (a copy of the file row that follows the cursor position) is created. The drag shadow element is created as a direct child of the body element, so it needs a higher "z-index" than the one used for the file list to be visible. In narrow screens the "#app-content" uses a "z-index" of 1000 in order to be visible over the "#navigation-bar" when they overlap, so the "z-index" of the drag shadow must be at least 1000 to be visible over the file list. Instead of updating the hardcoded "z-index" it was removed and replaced by CSS rules for ".dragshadow" elements to ease theming. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Codecov Report
@@ Coverage Diff @@## stable12 #7666 +/- ##
===========================================
Coverage 53.93% 53.93% Complexity 22712 22712 ===========================================
Files 1385 1385 Lines 86996 86996 Branches 1330 1330 ===========================================
Hits 46919 46919 Misses 40077 40077 |
rullzer
approved these changes
Jan 5, 2018
MorrisJobke
deleted the
stable12-7527-fix-drag-shadow-not-visible-when-dragging-a-file-on-a-narrow-screen
branch
January 9, 2018 10:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7527