Skip to content

Fix inverted app icons on IE11 - #7669

Merged
MorrisJobke merged 4 commits into
masterfrom
ie-fix-invert
Jan 3, 2018
Merged

Fix inverted app icons on IE11#7669
MorrisJobke merged 4 commits into
masterfrom
ie-fix-invert

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Jan 3, 2018•
edited by rullzer
Loading

Copy link
Copy Markdown
Member

Fixes#7408

This PR also includes some minor fixes to the apps management on IE11.

Before:
bildschirmfoto vom 2018-01-03 09-20-50

After:
bildschirmfoto vom 2018-01-03 09-21-32

Tested with Chrome, Firefox and IE11

@nextcloud/designers

@juliusknorrjuliusknorr added 3. to review Waiting for reviews bug design Design, UI, UX, etc. high labels Jan 3, 2018
@juliusknorrjuliusknorr added this to the Nextcloud 13 milestone Jan 3, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Jan 3, 2018
Merged
30 tasks
@codecov

codecovBot commented Jan 3, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7669 into master will decrease coverage by <.01%.
The diff coverage is 3.57%.

@@ Coverage Diff @@## master #7669 +/- ##
============================================
- Coverage 51.2% 51.19% -0.01% - Complexity 24893 24894 +1 
============================================
Files 1602 1602 Lines 94804 94813 +9 Branches 1372 1373 +1 ============================================
Hits 48543 48543 - Misses 46261 46270 +9
Impacted FilesCoverage ΔComplexity Δ
settings/templates/apps.php0% <ø> (ø)0 <0> (ø)⬇️
lib/private/TemplateLayout.php0% <0%> (ø)46 <0> (+1)⬆️
core/templates/layout.user.php0% <0%> (ø)0 <0> (ø)⬇️
settings/js/apps.js24.39% <4.54%> (-0.28%)0 <0> (ø)
apps/files_trashbin/lib/Expiration.php90.32% <0%> (-1.62%)29% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️

@MorrisJobke

MorrisJobke commented Jan 3, 2018

Copy link
Copy Markdown
Member

@juliushaertl is it possible to backport this to stable12?

@MorrisJobke

MorrisJobke commented Jan 3, 2018

Copy link
Copy Markdown
Member

Now it does work in IE11 but not in Edge anymore :/ (the icon itself is white but the app icons are also invisible)

bildschirmfoto 2018-01-03 um 11 08 11

@juliusknorrjuliusknorr added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 3, 2018
@juliusknorr
Invert app icons on IE11 as well
8a22681
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Fix icon rendering in apps management for IE11
7f86d4a
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Fix height of table rows in apps management on IE11
a79d276
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Remove css invert since we are using svg filters for now
63b4d7e
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorrjuliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 3, 2018
@juliusknorr

juliusknorr commented Jan 3, 2018

Copy link
Copy Markdown
MemberAuthor

@MorrisJobke Fixed for edge as well. 😉

@MorrisJobke

MorrisJobke commented Jan 3, 2018

Copy link
Copy Markdown
Member

IE is still not working (I used a light grey to check if the icons are there and rendered white or if they are somehow corrupted):

bildschirmfoto 2018-01-03 um 15 25 43

Top to bottom: Firefox, Chrome, Safari, Edge, IE11.

@juliusknorr

juliusknorr commented Jan 3, 2018

Copy link
Copy Markdown
MemberAuthor

@MorrisJobke That's quite strange. Works fine here with Edge and IE11

@MorrisJobke

MorrisJobke commented Jan 3, 2018

Copy link
Copy Markdown
Member

@MorrisJobke That's quite strange. Works fine here with Edge and IE11

Let me retest this then :)

MorrisJobke
MorrisJobke approved these changes Jan 3, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works now ... I guess it was a caching issue, because I rolled back and forward a lot on this instance. With a fresh install it worked fine. 👍

@MorrisJobke
MorrisJobke merged commit 722097f into masterJan 3, 2018
@MorrisJobke
MorrisJobke deleted the ie-fix-invert branch January 3, 2018 15:58
@MorrisJobke

MorrisJobke commented Jan 3, 2018

Copy link
Copy Markdown
Member

@juliushaertl Could we backport this to stable12?

@juliusknorr

juliusknorr commented Jan 3, 2018

Copy link
Copy Markdown
MemberAuthor

I see no problem there, let me have a look.

@juliusknorrjuliusknorr mentioned this pull request Jan 3, 2018
Merged
@juliusknorr

juliusknorr commented Jan 3, 2018

Copy link
Copy Markdown
MemberAuthor

backported at #7684

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@pixelipopixelipoAwaiting requested review from pixelipo

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.high

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

IE11 with white theming doesn't show black app icons

3 participants

@juliusknorr@MorrisJobke@skjnldsv