Skip to content

[stable12] Don't attempt to translate login names to uids when uids are provided - #7694

Merged
rullzer merged 5 commits into
stable12from
stable12-7611
Jan 8, 2018
Merged

[stable12] Don't attempt to translate login names to uids when uids are provided#7694
rullzer merged 5 commits into
stable12from
stable12-7611

Conversation

@blizzz

@blizzzblizzz commented Jan 4, 2018

Copy link
Copy Markdown
Member

Backport of #7611

@blizzz
extend tests for status quo
c94c2c4
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
never translate login names when requiring with a user id
776d9e6
where appropriate, the preLoginNameUsedAsUserName hook should be thrown.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
removes invalid tests, adapts another one
e489a1a
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added 3. to review Waiting for reviews bug labels Jan 4, 2018
@blizzzblizzz added this to the Nextcloud 12.0.5 milestone Jan 4, 2018
@blizzz
update autoloader
7f0e4a5
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@codecov

codecovBot commented Jan 4, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7694 into stable12 will decrease coverage by 23.06%.
The diff coverage is 100%.

@@ Coverage Diff @@## stable12 #7694 +/- ##
===============================================
- Coverage 53.93% 30.86% -23.07% + Complexity 22712 22709 -3 
===============================================
Files 1385 1385 Lines 86996 86994 -2 Branches 1330 1330 ===============================================
- Hits 46918 26851 -20067 - Misses 40078 60143 +20065
Impacted FilesCoverage ΔComplexity Δ
lib/private/User/Manager.php26.04% <ø> (-58.81%)74 <0> (-3)
core/Controller/LostController.php80.53% <100%> (+0.53%)29 <0> (ø)⬇️
lib/public/Files/ForbiddenException.php0% <0%> (-100%)2% <0%> (ø)
...yBuilder/FunctionBuilder/SqliteFunctionBuilder.php0% <0%> (-100%)1% <0%> (ø)
lib/private/DB/QueryBuilder/QueryFunction.php0% <0%> (-100%)2% <0%> (ø)
...s/dav/lib/Connector/Sabre/Exception/FileLocked.php0% <0%> (-100%)3% <0%> (ø)
lib/private/Files/Cache/Wrapper/JailPropagator.php0% <0%> (-100%)1% <0%> (ø)
lib/private/Share20/Hooks.php0% <0%> (-100%)3% <0%> (ø)
apps/dav/lib/Connector/Sabre/Server.php0% <0%> (-100%)1% <0%> (ø)
apps/files_versions/lib/Command/Expire.php0% <0%> (-100%)3% <0%> (ø)
... and 369 more

@blizzz
test adoption for stable12
32597f8
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz mentioned this pull request Jan 4, 2018
Merged
@MorrisJobkeMorrisJobke mentioned this pull request Jan 8, 2018
Merged
13 tasks
rullzer
rullzer approved these changes Jan 8, 2018
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer
rullzer merged commit 1f875ec into stable12Jan 8, 2018
@rullzer
rullzer deleted the stable12-7611 branch January 8, 2018 20:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 12.0.5

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@rullzer@MorrisJobke