Skip to content

[stable11] Don't attempt to translate login names to uids when uids are provided - #7695

Merged
rullzer merged 5 commits into
stable11from
stable11-7694
Jan 8, 2018
Merged

[stable11] Don't attempt to translate login names to uids when uids are provided#7695
rullzer merged 5 commits into
stable11from
stable11-7694

Conversation

@blizzz

@blizzzblizzz commented Jan 4, 2018

Copy link
Copy Markdown
Member

Backport of #7611

@blizzz
extend tests for status quo
3c87faa
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
never translate login names when requiring with a user id
4ea73b8
where appropriate, the preLoginNameUsedAsUserName hook should be thrown.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
removes invalid tests, adapts another one
053d60c
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added 3. to review Waiting for reviews bug labels Jan 4, 2018
@blizzzblizzz added this to the Nextcloud 11.0.7 milestone Jan 4, 2018
@blizzz
update autoloader
bc00d70
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@codecov

codecovBot commented Jan 4, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7695 into stable11 will decrease coverage by 24.87%.
The diff coverage is 100%.

@@ Coverage Diff @@## stable11 #7695 +/- ##
===============================================
- Coverage 57.55% 32.67% -24.88% + Complexity 19603 19255 -348 
===============================================
Files 1221 1214 -7 Lines 73007 69965 -3042 Branches 1241 1241 ===============================================
- Hits 42016 22864 -19152 - Misses 30991 47101 +16110
Impacted FilesCoverage ΔComplexity Δ
lib/private/User/Manager.php25.92% <ø> (-57.51%)63 <0> (-3)
core/Controller/LostController.php100% <100%> (+18.26%)25 <0> (ø)⬇️
ocs/routes.php0% <0%> (-100%)0% <0%> (ø)
apps/dav/lib/CalDAV/PublicCalendarRoot.php0% <0%> (-100%)4% <0%> (ø)
apps/dav/lib/Connector/Sabre/Server.php0% <0%> (-100%)1% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFix.php0% <0%> (-100%)5% <0%> (ø)
lib/private/TagManager.php0% <0%> (-100%)4% <0%> (ø)
apps/files_sharing/lib/External/MountProvider.php0% <0%> (-100%)4% <0%> (ø)
...ps/comments/tests/Unit/AppInfo/ApplicationTest.php0% <0%> (-100%)4% <0%> (ø)
...yBuilder/FunctionBuilder/SqliteFunctionBuilder.php0% <0%> (-100%)1% <0%> (ø)
... and 507 more

@blizzz
test adoption for stable12 and stable11
9ac1c48
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz mentioned this pull request Jan 4, 2018
Merged
@MorrisJobkeMorrisJobke mentioned this pull request Jan 8, 2018
Merged
2 tasks
rullzer
rullzer approved these changes Jan 8, 2018
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer
rullzer merged commit bb59107 into stable11Jan 8, 2018
@rullzer
rullzer deleted the stable11-7694 branch January 8, 2018 20:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 11.0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@rullzer@MorrisJobke