Uh oh!
There was an error while loading. Please reload this page.
Use correct L10N files for jsconfig - #7712
Merged
Merged
Conversation
rullzer
requested review from
MorrisJobke, danxuliu, juliusknorr and nickvergessenJanuary 5, 2018 13:01
| public function __construct($appName, | ||
| IRequest $request, | ||
| IL10N $l, | ||
| IFactory $l, |
Member
There was a problem hiding this comment.
mind renaming it to something other than $l its quite confusing, because $l is reserved for IL10N
nickvergessen
approved these changes
Jan 5, 2018
nickvergessen
left a comment
Member
There was a problem hiding this comment.
"Moments when I have DI magic" +1
Codecov Report
@@ Coverage Diff @@## master #7712 +/- ##
============================================
+ Coverage 51.18% 51.18% +<.01%
Complexity 24948 24948 ============================================
Files 1605 1605 Lines 94923 94923 Branches 1376 1376 ============================================
+ Hits 48583 48584 +1 + Misses 46340 46339 -1
|
| public function __construct($appName, | ||
| IRequest $request, | ||
| IL10N $l, | ||
| IFactory $l10Factory, |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
juliusknorr
approved these changes
Jan 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test:
Before: still english
Now: Properly translated