Skip to content

Fix LDAP Background Sync does not reset offset - #7713

Merged
MorrisJobke merged 7 commits into
masterfrom
fix-sync-offset
Jan 9, 2018
Merged

Fix LDAP Background Sync does not reset offset#7713
MorrisJobke merged 7 commits into
masterfrom
fix-sync-offset

Conversation

@blizzz

Copy link
Copy Markdown
Member

As observed on our instance… issue was that it was reported that more results are expected, while the count was already below the requested limit.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added this to the Nextcloud 13 milestone Jan 5, 2018
@codecov

codecovBot commented Jan 5, 2018

Copy link
Copy Markdown

Codecov Report

Merging #7713 into master will increase coverage by 0.05%.
The diff coverage is 24.39%.

@@ Coverage Diff @@## master #7713 +/- ##
============================================
+ Coverage 51.18% 51.23% +0.05% - Complexity 24948 24954 +6 
============================================
Files 1605 1607 +2 Lines 94923 94957 +34 Branches 1376 1376 ============================================
+ Hits 48583 48652 +69 + Misses 46340 46305 -35
Impacted FilesCoverage ΔComplexity Δ
...ps/user_ldap/composer/composer/autoload_static.php0% <ø> (ø)1 <0> (ø)⬇️
apps/user_ldap/lib/ConnectionFactory.php0% <0%> (ø)2 <2> (?)
apps/user_ldap/lib/AccessFactory.php0% <0%> (ø)2 <2> (?)
.../user_ldap/composer/composer/autoload_classmap.php0% <0%> (ø)0 <0> (ø)⬇️
apps/user_ldap/lib/Jobs/Sync.php64% <52.63%> (+37.61%)46 <9> (+2)⬆️

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz

Copy link
Copy Markdown
MemberAuthor

I added several more tests, and fixed one issue with that.

On our instance I see that the offset is not being reset, this should have been fixed though, but isn't. New addition is about rotating the prefix which does not apply to us.

@MorrisJobke
MorrisJobke merged commit 167f462 into masterJan 9, 2018
@MorrisJobke
MorrisJobke deleted the fix-sync-offset branch January 9, 2018 17:39
@MorrisJobkeMorrisJobke mentioned this pull request Jan 9, 2018
18 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: ldap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@rullzer@MorrisJobke