Uh oh!
There was an error while loading. Please reload this page.
Fix "New" menu shown behind the multiselect header in the file list - #7728
Merged
MorrisJobke merged 1 commit intoJan 8, 2018
Merged
Conversation
The "New" menu is a descendant of the controls bar, and the controls bar and the multiselect header belong to the same stacking context. As they had the same z-index but the multiselect header appears after the controls bar in the DOM the controls bar and its descendants, including the "New" menu, were rendered behind the multiselect header. Now the controls bar has a z-index value higher than the one used for the multiselect header to ensure that the "New" menu is rendered in front of the multiselect header. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
skjnldsv
approved these changes
Jan 8, 2018
Codecov Report
@@ Coverage Diff @@## master #7728 +/- ##
=========================================
Coverage 51.18% 51.18% Complexity 24948 24948 =========================================
Files 1605 1605 Lines 94923 94923 Branches 1376 1376 =========================================
Hits 48584 48584 Misses 46339 46339
|
MorrisJobke
approved these changes
Jan 8, 2018
MorrisJobke
deleted the
fix-new-menu-shown-behind-the-controls-in-the-file-list
branch
January 8, 2018 07:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a regression introduced in #7663
The New menu is a descendant of the controls bar, and the controls bar and the multiselect header belong to the same stacking context. As they had the same z-index but the multiselect header appears after the controls bar in the DOM the controls bar and its descendants, including the New menu, were rendered behind the multiselect header.
Now the controls bar has a z-index value higher than the one used for the multiselect header to ensure that the New menu is rendered in front of the multiselect header.
@nextcloud/designers