Uh oh!
There was an error while loading. Please reload this page.
Improve shadow of tooltips - #7729
Merged
Merged
Conversation
juliusknorr
requested review from
MorrisJobke, danxuliu, jancborchardt and skjnldsvJanuary 8, 2018 09:26
Codecov Report
@@ Coverage Diff @@## master #7729 +/- ##
============================================
+ Coverage 51.12% 51.17% +0.05%
Complexity 24948 24948 ============================================
Files 1605 1605 Lines 94923 94923 Branches 1376 1376 ============================================
+ Hits 48528 48579 +51 + Misses 46395 46344 -51
|
| .ie .tooltip-inner { | ||
| box-shadow: 0 1px 10px $color-box-shadow; | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
Could you add this to the fixes.css?
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorrforce-pushed
the
fix-tooltip-shadow
branch
from
January 8, 2018 10:41
c30489e to
27f00bfCompareMorrisJobke
approved these changes
Jan 8, 2018
skjnldsv
approved these changes
Jan 9, 2018
jancborchardt
approved these changes
Jan 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tooltips now have the same drop shadow that includes the arrow as the other popover elements.
Before / IE fallback:
After:
@nextcloud/designers