Uh oh!
There was an error while loading. Please reload this page.
The max_scale_factor is not used anymore. - #7733
Merged
Merged
Conversation
We never generate previews larger than the original. So the config setting can be removed. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
nickvergessen
approved these changes
Jan 8, 2018
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Also mentioned in the README of the gallery app
MorrisJobke
approved these changes
Jan 8, 2018
MorrisJobke
commented
Jan 8, 2018
Member
|
Codecov Report
@@ Coverage Diff @@## master #7733 +/- ##
============================================
+ Coverage 51.12% 51.18% +0.05%
Complexity 24948 24948 ============================================
Files 1605 1605 Lines 94923 94922 -1 Branches 1376 1376 ============================================
+ Hits 48528 48584 +56 + Misses 46395 46338 -57
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We never generate previews larger than the original. So the config
setting can be removed.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl