opens comments links in _blank 🙊

[blizzz]

cf. #7680 (comment) ff

I'll go and do an app that fixes this bug (imo) then later.

@jancborchardt

[codecov]

Codecov Report

Merging #7739 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #7739 +/- ##
============================================
- Coverage 51.18% 51.18% -0.01% 
Complexity 24948 24948 ============================================
Files 1605 1605 Lines 94922 94922 Branches 1376 1376 ============================================
- Hits 48584 48583 -1 - Misses 46338 46339 +1

Impacted Files	Coverage Δ	Complexity Δ
core/js/public/comments.js	68.18% <0%> (ø)	0 <0> (ø)	⬇️
lib/private/Security/CertificateManager.php	91.08% <0%> (-1%)	39% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php	72.28% <0%> (-0.25%)	136% <0%> (ø)
lib/private/Server.php	81.55% <0%> (+0.11%)	134% <0%> (ø)	⬇️

[jancborchardt]

Thanks a lot for fixing this @blizzz! :) 🎉

[blizzz]

I'll go and do an app that fixes this bug (imo) then later.

DefaultLinkOpen will enter appstore when the rc is available.

[jancborchardt]

@blizzz as soon as you or someone you have a call with accidentally drops from it as a result of clicking a link, I suggest you take it out of the store. ;)

[blizzz]

🙊

[jancborchardt]

Btw, see this article: When to use target=”_blank”

A Good Reason: The user is working on something on the page, that might be lost if the current page changed.

@blizzz ;D

[blizzz]

@jancborchardt might very well be. My personal reality is different. My personal XP is that I am frustrated when new tabs open, when I want them to open where I am. This happens just too often, and there are already too many things going on in this world that are frustrating or worse. Please respect my attitude towards _blank. Please accept that it is as it is independent of how many honestly good reasons you find. I am able to open a link in a new tab when I intend to do so. This is deeply rooted in my muscle-or-whatever memory.