Skip to content

[stable12] add option to use legacy v2 auth with s3 - #7758

Merged
rullzer merged 1 commit into
stable12from
12-7570
Jan 9, 2018
Merged

[stable12] add option to use legacy v2 auth with s3#7758
rullzer merged 1 commit into
stable12from
12-7570

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Backport of #7570

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Jan 9, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 12.0.5 milestone Jan 9, 2018
@mention-bot

Copy link
Copy Markdown

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic to be a potential reviewer.

@MorrisJobkeMorrisJobke mentioned this pull request Jan 9, 2018
13 tasks
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

I just tested it and it still works 👍

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 9, 2018
Signed-off-by: Robin Appelman <robin@icewind.nl>
@codecov

codecovBot commented Jan 9, 2018

Copy link
Copy Markdown

Codecov Report

Merging #7758 into stable12 will increase coverage by 1.97%.
The diff coverage is 6.54%.

@@ Coverage Diff @@## stable12 #7758 +/- ##
==============================================
+ Coverage 53.9% 55.88% +1.97% + Complexity 22724 21222 -1502 
==============================================
Files 1384 1290 -94 Lines 87036 81126 -5910 Branches 1331 1331 ==============================================
- Hits 46920 45337 -1583 + Misses 40116 35789 -4327
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/ObjectStore/S3Signature.php0% <0%> (ø)28 <28> (?)
...ib/private/Files/ObjectStore/S3ConnectionTrait.php68.08% <77.77%> (+10.3%)28 <3> (+5)⬆️
lib/private/Memcache/Memcached.php0% <0%> (-57.9%)31% <0%> (ø)
lib/private/Files/Storage/DAV.php7.29% <0%> (-57.53%)161% <0%> (ø)
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)
lib/private/Repair/Collation.php0% <0%> (ø)16% <0%> (ø)⬇️
apps/dav/lib/CalDAV/Activity/Provider/Calendar.php0% <0%> (ø)43% <0%> (ø)⬇️
apps/files_external/lib/AppInfo/Application.php
...xternal/lib/Lib/Auth/Password/LoginCredentials.php
apps/files_external/lib/Command/Export.php
... and 136 more

@rullzer
rullzer merged commit 323dc4a into stable12Jan 9, 2018
@rullzer
rullzer deleted the 12-7570 branch January 9, 2018 20:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@mention-bot@rullzer@icewind1991