Uh oh!
There was an error while loading. Please reload this page.
Log a missing setting as INFO not as WARNING - #7766
Merged
Merged
Conversation
It can happen for all kinds of reasons that a setting is not available. (A user removes a folder, a setting got deleted). So don't polute the log on default settings. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Codecov Report
@@ Coverage Diff @@## master #7766 +/- ##
=========================================
Coverage 51.22% 51.22% Complexity 24967 24967 =========================================
Files 1607 1607 Lines 94989 94989 Branches 1376 1376 =========================================
Hits 48662 48662 Misses 46327 46327
|
MorrisJobke
approved these changes
Jan 10, 2018
blizzz
approved these changes
Jan 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can happen for all kinds of reasons that a setting is not available.
(A user removes a folder, a setting got deleted). So don't polute the
log on default settings.
For #7755. We should look into the reason for this happening exactly in #7755 but to me it seems unrelated to this log spamming ;)