More detailed theming capabilities

[juliusknorr]

This will allow clients to easily check if a custom background or a plain background color is used.

New entries in the capabilities theming section:

 "background-plain": false,
"background-default": true

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@9c01708). Click here to learn what that means.
The diff coverage is 100%.

@@ Coverage Diff @@## master #7776 +/- ##
=========================================
Coverage ? 51.21% Complexity ? 24982 =========================================
Files ? 1607 Lines ? 95021 Branches ? 1376 =========================================
Hits ? 48667 Misses ? 46354 Partials ? 0

Impacted Files	Coverage Δ	Complexity Δ
apps/theming/lib/Capabilities.php	83.33% <100%> (ø)	3 <0> (?)
apps/theming/lib/ThemingDefaults.php	91.79% <100%> (ø)	46 <0> (?)
apps/theming/lib/Util.php	93.47% <100%> (ø)	34 <4> (?)

[juliusknorr]

@tobiasKaminsky This is what you asked for the android app. You can now just check for boolean values instead of doing string comparisons 😉

Besides that I'm not sure if we can still bring this in 13? @MorrisJobke

[tobiasKaminsky]

Cool. Would be great to have this in NC13 :-)

[MorrisJobke]

Tested and works 👍

[tobiasKaminsky]

I get

<background-plain></background-plain>
<background-default>1</background-default>

on master with set background color and default background image (dots).

[juliusknorr]

@tobiasKaminsky The output I posted above was from requesting the capabilities in JSON. It seems like OCS XML responses convert boolean values to 1 for true and empty for false.

Anyway the result is correct. True that the default background image is used, false that a plain background color (without an image) is used.

[tobiasKaminsky]

Thank you for the quick response and explanation 👍

[marinofaggiana]

Nice.