Uh oh!
There was an error while loading. Please reload this page.
Fix empty details view after renaming a file - #7783
Merged
juliusknorr merged 3 commits intoJan 11, 2018
Merged
Conversation
All the tests in the "Renaming files" section added the test files, although those calling "doRename()" added them by setting a path for the file too. However, the path is ignored in the other tests, so adding the files can be unified and moved to "beforeEach()". This would be needed, for example, to show the details view for a file before calling "doRename()". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
"FileList._updateDetailsView" expects either a file name (as a string) or a file model (as an "OCA.File.FileInfoModel"), but when called through "updateInList" an "OC.Files.FileInfo" object was given instead. As the given attribute was not a model "_updateDetailsView" treated it as a file name and tried to get the model for that file, which failed and caused the details view to be emptied. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Codecov Report
@@ Coverage Diff @@## master #7783 +/- ##
=========================================
Coverage 51.22% 51.22% Complexity 24967 24967 =========================================
Files 1607 1607 Lines 95002 95002 Branches 1376 1376 =========================================
Hits 48668 48668 Misses 46334 46334
|
rullzer
approved these changes
Jan 11, 2018
juliusknorr
approved these changes
Jan 11, 2018
danxuliu
commented
Jan 11, 2018
MemberAuthor
Backported in #7792 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileList._updateDetailsViewexpects either a file name (as a string) or a file model (as anOCA.File.FileInfoModel), but when called throughupdateInListanOC.Files.FileInfoobject was given instead. As the given attribute was not a model_updateDetailsViewtreated it as a file name and tried to get the model for that file, which failed and caused the details view to be emptied.