Skip to content

Adds rel="noopener noreferrer" to _blank links inside comments - #7787

Merged
rullzer merged 1 commit into
masterfrom
add-noopener-to-_blank-links
Jan 11, 2018
Merged

Adds rel="noopener noreferrer" to _blank links inside comments#7787
rullzer merged 1 commit into
masterfrom
add-noopener-to-_blank-links

Conversation

@tcitworld

Copy link
Copy Markdown
Member

For more details, check out https://mathiasbynens.github.io/rel-noopener/ for instance

Suggestion from #7680

For more details, check out https://mathiasbynens.github.io/rel-noopener/ for instance
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@rullzerrullzer added this to the Nextcloud 13 milestone Jan 11, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Jan 11, 2018
18 tasks
@blizzzblizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 11, 2018
@codecov

codecovBot commented Jan 11, 2018

Copy link
Copy Markdown

Codecov Report

Merging #7787 into master will not change coverage.
The diff coverage is 0%.

@@ Coverage Diff @@## master #7787 +/- ##
=========================================
Coverage 51.22% 51.22% Complexity 24967 24967 =========================================
Files 1607 1607 Lines 95002 95002 Branches 1376 1376 =========================================
Hits 48668 48668 Misses 46334 46334
Impacted FilesCoverage ΔComplexity Δ
core/js/public/comments.js68.18% <0%> (ø)0 <0> (ø)⬇️
lib/private/Security/CertificateManager.php91.08% <0%> (-1%)39% <0%> (ø)
lib/private/Server.php81.55% <0%> (+0.11%)134% <0%> (ø)⬇️

@rullzer
rullzer merged commit 118ccca into masterJan 11, 2018
@rullzer
rullzer deleted the add-noopener-to-_blank-links branch January 11, 2018 10:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: commentssecurity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tcitworld@rullzer@juliusknorr@blizzz