Skip to content

Fix popover and styling in user management - #7790

Merged
MorrisJobke merged 1 commit into
masterfrom
usermanagement-fixes
Jan 11, 2018
Merged

Fix popover and styling in user management#7790
MorrisJobke merged 1 commit into
masterfrom
usermanagement-fixes

Conversation

@juliusknorr

Copy link
Copy Markdown
Member
  • Fix popover positioning
  • Always show the 3-dots icon
  • Remove margin between new user form and table

Before:
bildschirmfoto vom 2018-01-11 12-15-39

After:
bildschirmfoto vom 2018-01-11 12-15-15

@nextcloud/designers

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@skjnldsv

Copy link
Copy Markdown
Member

Popover fix already included in the new user menu pr I did! :)

@MorrisJobke

Copy link
Copy Markdown
Member

Popover fix already included in the new user menu pr I did! :)

But it will not go into Nextcloud 13 ;)

@MorrisJobkeMorrisJobke mentioned this pull request Jan 11, 2018
18 tasks
@skjnldsv

skjnldsv commented Jan 11, 2018

Copy link
Copy Markdown
Member

But it will not go into Nextcloud 13 ;)

It could! :'(
But I like this fix better! LGTM!

@codecov

codecovBot commented Jan 11, 2018

Copy link
Copy Markdown

Codecov Report

Merging #7790 into master will decrease coverage by 2.02%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #7790 +/- ##
============================================
- Coverage 53.24% 51.22% -2.03% - Complexity 23656 24968 +1312 
============================================
Files 1514 1607 +93 Lines 88252 95007 +6755 Branches 1376 1376 ============================================
+ Hits 46994 48669 +1675 - Misses 41258 46338 +5080
Impacted FilesCoverage ΔComplexity Δ
settings/templates/users/part.userlist.php0% <0%> (ø)0 <0> (ø)⬇️
.../tests/Unit/Collaboration/CommentersSorterTest.php25.55% <0%> (-66.45%)6% <0%> (ø)
apps/sharebymail/tests/SettingsTest.php52.17% <0%> (-47.83%)3% <0%> (ø)
lib/private/Security/RateLimiting/Limiter.php55.55% <0%> (-44.45%)5% <0%> (ø)
settings/Controller/EncryptionController.php54.71% <0%> (-38.84%)8% <0%> (ø)
settings/Controller/GroupsController.php64.61% <0%> (-35.39%)9% <0%> (ø)
...ps/comments/tests/Unit/AppInfo/ApplicationTest.php69.56% <0%> (-30.44%)4% <0%> (ø)
lib/private/AvatarManager.php71.42% <0%> (-28.58%)4% <0%> (ø)
apps/user_ldap/lib/Configuration.php42.02% <0%> (-27.86%)87% <0%> (ø)
apps/encryption/lib/Command/EnableMasterKey.php75% <0%> (-25%)5% <0%> (ø)
... and 282 more

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit cc410fb into masterJan 11, 2018
@MorrisJobke
MorrisJobke deleted the usermanagement-fixes branch January 11, 2018 13:01
@skjnldsvskjnldsv mentioned this pull request Jan 11, 2018
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.feature: users and groups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@skjnldsv@MorrisJobke@MariusBluem