Skip to content

Make sure the arrays are arrays - #7812

Merged
rullzer merged 1 commit into
masterfrom
make-sure-the-arrays-are-arrays
Jan 12, 2018
Merged

Make sure the arrays are arrays#7812
rullzer merged 1 commit into
masterfrom
make-sure-the-arrays-are-arrays

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

I don't know why, but on the call to preDelete the dav HookManager seems to not be registered yet, and then postDelete failed with foreach and null:
https://travis-ci.org/nextcloud/activity/jobs/328063705#L726

Signed-off-by: Joas Schilling <coding@schilljs.com>
@codecov

codecovBot commented Jan 12, 2018

Copy link
Copy Markdown

Codecov Report

Merging #7812 into master will decrease coverage by 1.64%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #7812 +/- ##
============================================
- Coverage 52.87% 51.23% -1.65% - Complexity 23658 24970 +1312 
============================================
Files 1449 1607 +158 Lines 80454 95008 +14554 Branches 0 1376 +1376 ============================================
+ Hits 42541 48674 +6133 - Misses 37913 46334 +8421
Impacted FilesCoverage ΔComplexity Δ
apps/dav/lib/HookManager.php51.78% <ø> (ø)15 <0> (ø)⬇️
.../tests/Unit/Collaboration/CommentersSorterTest.php25.55% <0%> (-66.45%)6% <0%> (ø)
apps/sharebymail/tests/SettingsTest.php52.17% <0%> (-47.83%)3% <0%> (ø)
lib/private/Security/RateLimiting/Limiter.php55.55% <0%> (-44.45%)5% <0%> (ø)
settings/Controller/EncryptionController.php54.71% <0%> (-38.84%)8% <0%> (ø)
settings/Controller/GroupsController.php64.61% <0%> (-35.39%)9% <0%> (ø)
...ps/comments/tests/Unit/AppInfo/ApplicationTest.php69.56% <0%> (-30.44%)4% <0%> (ø)
lib/private/AvatarManager.php71.42% <0%> (-28.58%)4% <0%> (ø)
apps/user_ldap/lib/Configuration.php42.02% <0%> (-27.86%)87% <0%> (ø)
apps/encryption/lib/Command/EnableMasterKey.php75% <0%> (-25%)5% <0%> (ø)
... and 348 more

@rullzer
rullzer merged commit 1993eb0 into masterJan 12, 2018
@rullzer
rullzer deleted the make-sure-the-arrays-are-arrays branch January 12, 2018 14:31
@rullzer

Copy link
Copy Markdown
Member

Still we should investigate the weird bug...

@MorrisJobke

Copy link
Copy Markdown
Member

@nickvergessen Could you open the backport PRs?

@MorrisJobkeMorrisJobke mentioned this pull request Jan 18, 2018
3 tasks
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

#7943

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@rullzer@MorrisJobke