Skip to content

Deprecated checkLoggedIn and other old ways to access control - #7877

Merged
MorrisJobke merged 1 commit into
masterfrom
deprecated-ocp-user
Jan 16, 2018
Merged

Deprecated checkLoggedIn and other old ways to access control#7877
MorrisJobke merged 1 commit into
masterfrom
deprecated-ocp-user

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Jan 16, 2018

Copy link
Copy Markdown
Member

I will also backport this to stable13.

@MorrisJobke
Deprecated checkLoggedIn and other old ways to access control
0f18085
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Jan 16, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 14 milestone Jan 16, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Jan 16, 2018
Merged
ChristophWurst
ChristophWurst approved these changes Jan 16, 2018
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 16, 2018
@codecov

codecovBot commented Jan 16, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7877 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #7877 +/- ##
============================================
- Coverage 51.24% 51.24% -0.01% 
Complexity 24931 24931 ============================================
Files 1604 1604 Lines 94970 94970 Branches 1376 1376 ============================================
- Hits 48670 48668 -2 - Misses 46300 46302 +2
Impacted FilesCoverage ΔComplexity Δ
lib/public/User.php50% <ø> (ø)10 <0> (ø)⬇️
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)
lib/private/Security/CertificateManager.php91.08% <0%> (-1%)39% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.28% <0%> (-0.25%)136% <0%> (ø)
lib/private/Server.php81.55% <0%> (+0.11%)134% <0%> (ø)⬇️

@MorrisJobke
MorrisJobke merged commit 4ae04c3 into masterJan 16, 2018
@MorrisJobke
MorrisJobke deleted the deprecated-ocp-user branch January 16, 2018 10:59
@nickvergessen

nickvergessen commented Jan 16, 2018

Copy link
Copy Markdown
Member

Please add it to the app code checker

@MorrisJobkeMorrisJobke mentioned this pull request Jan 16, 2018
Merged
@MorrisJobke

MorrisJobke commented Jan 16, 2018

Copy link
Copy Markdown
MemberAuthor

Please add it to the app code checker

#7885

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@blizzzblizzzAwaiting requested review from blizzz

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@nickvergessen@rullzer@ChristophWurst