Skip to content

Fix the type hints of migrations and correctly inject the wrapped sch… - #7909

Merged
MorrisJobke merged 1 commit into
masterfrom
fix-migration-type-hints
Jan 17, 2018
Merged

Fix the type hints of migrations and correctly inject the wrapped sch…#7909
MorrisJobke merged 1 commit into
masterfrom
fix-migration-type-hints

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jan 17, 2018

Copy link
Copy Markdown
Member

…ema into migrations
Signed-off-by: Joas Schilling <coding@schilljs.com>
@codecov

codecovBot commented Jan 17, 2018

Copy link
Copy Markdown

Codecov Report

Merging #7909 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #7909 +/- ##
============================================
- Coverage 51.23% 51.15% -0.09% - Complexity 24920 24983 +63 
============================================
Files 1604 1604 Lines 94968 95124 +156 Branches 1376 1376 ============================================
- Hits 48658 48657 -1 - Misses 46310 46467 +157
Impacted FilesCoverage ΔComplexity Δ
core/Command/Db/Migrations/GenerateCommand.php0% <ø> (ø)13 <0> (ø)⬇️
...av/lib/Migration/Version1004Date20170825134824.php0% <ø> (ø)12 <0> (ø)⬇️
...es/lib/Migration/Version1002Date20170607113030.php0% <ø> (ø)6 <0> (ø)⬇️
...av/lib/Migration/Version1004Date20170926103422.php0% <ø> (ø)1 <0> (ø)⬇️
core/Migrations/Version13000Date20170718121200.php0% <ø> (ø)30 <0> (ø)⬇️
core/Migrations/Version13000Date20170814074715.php0% <ø> (ø)4 <0> (ø)⬇️
lib/public/Migration/BigIntMigration.php0% <ø> (ø)4 <0> (ø)⬇️
...es/lib/Migration/Version1002Date20170607104347.php0% <ø> (ø)2 <0> (ø)⬇️
...es/lib/Migration/Version1002Date20170926101419.php0% <ø> (ø)1 <0> (ø)⬇️
core/Migrations/Version13000Date20170705121758.php0% <ø> (ø)3 <0> (ø)⬇️
... and 12 more

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit 24c58d3 into masterJan 17, 2018
@MorrisJobke
MorrisJobke deleted the fix-migration-type-hints branch January 17, 2018 12:48
splitt3r added a commit to nextcloud/polls that referenced this pull request Jan 17, 2018
splitt3r added a commit to nextcloud/polls that referenced this pull request Jan 17, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@rullzer@MorrisJobke