Skip to content

Removed additional and uneccessary request on password reset - #7921

Merged
MorrisJobke merged 1 commit into
masterfrom
fix_redirect_on_pw_reset
Jan 24, 2018
Merged

Removed additional and uneccessary request on password reset#7921
MorrisJobke merged 1 commit into
masterfrom
fix_redirect_on_pw_reset

Conversation

@lal12

Copy link
Copy Markdown
Contributor

Changes where already accepted in #7691 .

Signed-off-by: Luca Adrian Lindhorst info@lucalindhorst.de

@rullzerrullzer added this to the Nextcloud 14 milestone Jan 17, 2018
@lal12

lal12 commented Jan 17, 2018

Copy link
Copy Markdown
ContributorAuthor

I don't really know your way of planning releases, but should this really don't come before nextcloud 14? This is just a bugfix and not a new feature even if it never worked before.

@rullzer

Copy link
Copy Markdown
Member

@lal12 I plan to backport it to 13. But we get features into master first ;)

…redirection afterwards.
Signed-off-by: Luca Adrian Lindhorst <info@lucalindhorst.de>
@juliusknorr
juliusknorrforce-pushed the fix_redirect_on_pw_reset branch from 6f3275e to 269ca40CompareJanuary 24, 2018 12:37
@codecov

codecovBot commented Jan 24, 2018

Copy link
Copy Markdown

Codecov Report

Merging #7921 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #7921 +/- ##
============================================
+ Coverage 51.22% 51.23% +0.01% - Complexity 24859 24922 +63 
============================================
Files 1598 1604 +6 Lines 94899 94982 +83 Branches 1376 1376 ============================================
+ Hits 48613 48666 +53 - Misses 46286 46316 +30
Impacted FilesCoverage ΔComplexity Δ
...updatenotification/lib/ResetTokenBackgroundJob.php57.14% <0%> (-30.36%)6% <0%> (+3%)
lib/private/Repair.php25.6% <0%> (-6.21%)19% <0%> (ø)
lib/private/Share/Share.php63.37% <0%> (-2.64%)421% <0%> (+13%)
...pps/files_external/lib/Service/StoragesService.php90.86% <0%> (-1.81%)59% <0%> (ø)
lib/private/Log.php79.12% <0%> (-1.1%)39% <0%> (ø)
...aring/lib/Controller/MountPublicLinkController.php20.58% <0%> (-0.94%)24% <0%> (ø)
lib/private/Preview/TXT.php73.52% <0%> (-0.76%)10% <0%> (ø)
...s/federation/lib/BackgroundJob/GetSharedSecret.php66.66% <0%> (-0.65%)21% <0%> (ø)
lib/private/Files/Storage/Local.php78.19% <0%> (-0.41%)86% <0%> (-3%)
core/Controller/AvatarController.php81.16% <0%> (-0.25%)31% <0%> (ø)
... and 66 more

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 24, 2018
@MorrisJobke

Copy link
Copy Markdown
Member

Looks like the two pending PRs are stalling -> merging for now.

Thanks for your contribution @lal12

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lal12@rullzer@MorrisJobke@juliusknorr