Skip to content

[12] Use S3Client::upload instead of splitting single/multipart upload ourselves - #8101

Merged
MorrisJobke merged 1 commit into
stable12from
s3-uploader-12
Feb 8, 2018
Merged

[12] Use S3Client::upload instead of splitting single/multipart upload ourselves#8101
MorrisJobke merged 1 commit into
stable12from
s3-uploader-12

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Backport of #8033

…selves
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Jan 29, 2018
@icewind1991icewind1991 added this to the Nextcloud 12.0.6 milestone Jan 29, 2018
@codecov

codecovBot commented Jan 29, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8101 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## stable12 #8101 +/- ##
==============================================
+ Coverage 53.84% 53.85% +<.01% + Complexity 22761 22753 -8 
==============================================
Files 1385 1385 Lines 87150 87121 -29 Branches 1331 1331 ==============================================
- Hits 46926 46915 -11 + Misses 40224 40206 -18
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/ObjectStore/S3ObjectTrait.php75% <100%> (+17.1%)5 <0> (-8)⬇️
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

MorrisJobke
MorrisJobke approved these changes Feb 8, 2018
@MorrisJobke
MorrisJobke merged commit 08a13dd into stable12Feb 8, 2018
@MorrisJobke
MorrisJobke deleted the s3-uploader-12 branch February 8, 2018 13:31
@MorrisJobkeMorrisJobke mentioned this pull request Mar 9, 2018
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@rullzer@MorrisJobke