Skip to content

[13] Use S3Client::upload instead of splitting single/multipart upload ourselves - #8102

Merged
MorrisJobke merged 1 commit into
stable13from
s3-uploader-13
Feb 8, 2018
Merged

[13] Use S3Client::upload instead of splitting single/multipart upload ourselves#8102
MorrisJobke merged 1 commit into
stable13from
s3-uploader-13

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Backport of #8033

…selves
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Jan 29, 2018
@icewind1991icewind1991 added this to the Nextcloud 13.0.1 milestone Jan 29, 2018
@codecov

codecovBot commented Jan 29, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8102 into stable13 will increase coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## stable13 #8102 +/- ##
==============================================
+ Coverage 51.23% 51.23% +<.01% + Complexity 24981 24973 -8 
==============================================
Files 1607 1607 Lines 95049 95020 -29 Branches 1376 1376 ==============================================
- Hits 48695 48684 -11 + Misses 46354 46336 -18
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/ObjectStore/S3ObjectTrait.php75% <100%> (+17.1%)5 <0> (-8)⬇️
lib/private/Security/CertificateManager.php91.08% <0%> (-1%)39% <0%> (ø)
lib/private/Server.php81.55% <0%> (+0.11%)134% <0%> (ø)⬇️
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke
MorrisJobke merged commit 197c97e into stable13Feb 8, 2018
@MorrisJobke
MorrisJobke deleted the s3-uploader-13 branch February 8, 2018 13:31
@MorrisJobkeMorrisJobke mentioned this pull request Mar 9, 2018
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@rullzer@MorrisJobke