Skip to content

Nextcloud 13 - #8109

Closed
MorrisJobke wants to merge 1 commit into
stable13from
final-13.0.0
Closed

Nextcloud 13#8109
MorrisJobke wants to merge 1 commit into
stable13from
final-13.0.0

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

No change (beside translations) to RC3 (#8027)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Jan 30, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 13 milestone Jan 30, 2018
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

@jospoortvliet Just for clarity: tomorrow is the day, right?

@codecov

codecovBot commented Jan 30, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8109 into stable13 will increase coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## stable13 #8109 +/- ##
==============================================
+ Coverage 51.23% 51.23% +<.01% 
Complexity 24981 24981 ==============================================
Files 1607 1607 Lines 95049 95049 Branches 1376 1376 ==============================================
+ Hits 48695 48696 +1 + Misses 46354 46353 -1
Impacted FilesCoverage ΔComplexity Δ
version.php0% <0%> (ø)0 <0> (ø)⬇️
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️

@pasxalisk

pasxalisk commented Jan 30, 2018

Copy link
Copy Markdown

Hello,

I noticed on the last versions of nextcloud (currently RC3 running on my raspberry pi 3) that althought with the latest upload in chuncks of 8192 fix when a large file(>2 GB) upload is completed i get the error message "Chunks on server do not sum up to XXX but to XXX" (same number).

A fix for that is done by changing the file /var/www/nextcloud/apps/dav/lib/Upload/ChunkingPlugin.php
Line 102: if ((int)$expectedSize !== $actualSize) {
With this: if ($expectedSize !== (string)$actualSize) {

Is this fix or any other workaround included in the 13 version?

Thank you

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

If the release is shifted by another week we maybe include #8112 into the 13.0.0 as well.

@ArjonBu

Copy link
Copy Markdown

@MorrisJobke I think the release should not be shifted again. Many people are looking forward to the new release with all the new features. It makes sense to add it to the next release.

@ghost

ghost commented Jan 30, 2018

Copy link
Copy Markdown

@arjoni We really want the new features (Nextcloud talk!), but if without #8112 it's not working on no 64bit machine it's can be really boring with ARM machine (not compatible with x64).

@ArjonBu

Copy link
Copy Markdown

@voxdemonix I see. That makes sense. I am curious why a week is needed to just change the variable from int to flow.

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

@MorrisJobke I think the release should not be shifted again. Many people are looking forward to the new release with all the new features. It makes sense to add it to the next release.

Talk with @jospoortvliet and @karlitschek about this 😉

@testbird

Copy link
Copy Markdown

Well, always watch out seriously if doing "float comparison" !
http://floating-point-gui.de/errors/comparison/

@jospoortvliet

Copy link
Copy Markdown
Member

Hey,

So the server is ready but we wanted to have a seriously testable desktop client release with E2EE ready. The first decent builds were made yesterday, today we felt it was time to move to Windows builds and hopefully by the end of the week we have Mac OS builds - so we think we can release next week, give people something to really test and play with.

Hope was we'd even have the E2EE stable by now but sadly, it is hard to do it right and we have to do it right (don't want to lose data, neither to hackers nor to crashes) so this will simply take a bit more time. Help welcome 😄

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Let's do a final RC until next week: #8127

@MorrisJobke
MorrisJobke deleted the final-13.0.0 branch January 31, 2018 14:57
@MorrisJobkeMorrisJobke removed this from the Nextcloud 13 milestone Jan 31, 2018
@yan12125yan12125 mentioned this pull request Jan 31, 2018
@tflidd

Copy link
Copy Markdown
Contributor

I pushed the realease date about one week on:
https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

@tflidd Thanks 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@MorrisJobke@pasxalisk@ArjonBu@testbird@jospoortvliet@tflidd@blizzz