Uh oh!
There was an error while loading. Please reload this page.
[stable13] Fixed app navigation flex margins - #8124
Merged
Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
BernhardPosselt, MorrisJobke, jancborchardt, juliusknorr and rullzerJanuary 31, 2018 13:57
rullzer
approved these changes
Jan 31, 2018
This was referenced Jan 31, 2018
Merged
MorrisJobke
commented
Jan 31, 2018
Member
Master version of this: #8128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleared some mess with the new guidelines, now we all have a proper padding/margins for the app navigation.
Fixesnextcloud/news#253
@BernhardPosselt
Template test:
templatetest.tar.gz
Simple explications:
I basically removed our negative margins, which was a terrible idea, and only compute the div width with flex and some forward margins/paddings., much easier to understand, simpler and efficient.
It also fix an overflow issue on firefox (see nextcloud/news#253)