Skip to content

Use correct update server - #8136

Merged
MorrisJobke merged 1 commit into
masterfrom
use-correct-update-server
Feb 1, 2018
Merged

Use correct update server#8136
MorrisJobke merged 1 commit into
masterfrom
use-correct-update-server

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Found here: https://help.nextcloud.com/t/call-for-testing-nextcloud-13-0-0-rc4/25435/77?u=morrisjobke

When the config.php has the update server set to the default one:

	'updater.server.url' => 'https://updates.nextcloud.com/updater_server/',

Then the warning that the non-default update server is in use was wrongly shown.

See

$updaterUrl = $this->config->getSystemValue('updater.server.url', 'https://updates.nextcloud.com/updater_server/');

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews backport-request papercut Annoying recurring UX issue with possibly simple fix. labels Feb 1, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 14 milestone Feb 1, 2018

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops...

@codecov

codecovBot commented Feb 1, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8136 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #8136 +/- ##
============================================
+ Coverage 51.73% 51.73% +<.01% 
Complexity 25357 25357 ============================================
Files 1598 1598 Lines 95020 95020 Branches 1376 1376 ============================================
+ Hits 49154 49155 +1 + Misses 45866 45865 -1
Impacted FilesCoverage ΔComplexity Δ
apps/updatenotification/lib/Settings/Admin.php77.5% <100%> (ø)8 <0> (ø)⬇️
apps/files_trashbin/lib/Trashbin.php72.7% <0%> (+0.24%)136% <0%> (ø)⬇️

@nickvergessen

Copy link
Copy Markdown
Member

I lost track of which one is the one to use by now

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

I lost track of which one is the one to use by now

Just use https://updates.nextcloud.com/updater_server/

The /server/ is the one for the old 10 instances that are not updatable via the build in tool :/

@MorrisJobke
MorrisJobke merged commit e28c407 into masterFeb 1, 2018
@MorrisJobke
MorrisJobke deleted the use-correct-update-server branch February 1, 2018 13:40
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Backport in #8142

@Bugsbane

Copy link
Copy Markdown
Member

I just updated from NC 13 > 14 > 15 and I'm getting this error in 15.0.7...

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

I just updated from NC 13 > 14 > 15 and I'm getting this error in 15.0.7...

Which one? The non-default server? Which one have you set? Please also open a new ticket then, because this is related but not the same issue then most likely.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewspapercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@nickvergessen@Bugsbane@rullzer