Skip to content

Fix styling issues of guest pages - #8155

Merged
MorrisJobke merged 3 commits into
masterfrom
use-guest-css
Feb 5, 2018
Merged

Fix styling issues of guest pages#8155
MorrisJobke merged 3 commits into
masterfrom
use-guest-css

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

This PR makes sure we use the guest.css file on all guest-template based pages that use the guest or error layout. Also fixes the regression from #8035

Before:
bildschirmfoto vom 2018-02-02 12-53-07
bildschirmfoto vom 2018-02-02 12-53-23
bildschirmfoto vom 2018-02-02 12-54-09

After:
bildschirmfoto vom 2018-02-02 12-58-37
bildschirmfoto vom 2018-02-02 12-58-22
bildschirmfoto vom 2018-02-02 12-58-01

@nextcloud/theming

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@codecov

codecovBot commented Feb 2, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8155 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #8155 +/- ##
============================================
+ Coverage 35.08% 35.08% +<.01% - Complexity 25357 25359 +2 
============================================
Files 1598 1598 Lines 95021 95023 +2 Branches 1376 1376 ============================================
+ Hits 33336 33337 +1 - Misses 61685 61686 +1
Impacted FilesCoverage ΔComplexity Δ
lib/private/TemplateLayout.php0% <0%> (ø)48 <0> (+2)⬆️
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

stable13: #8286

skjnldsv added a commit that referenced this pull request Feb 9, 2018
[13] Fix styling issues of guest pages #8155
@MorrisJobkeMorrisJobke mentioned this pull request Mar 9, 2018
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: theming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@rullzer@skjnldsv@MorrisJobke