Skip to content

Use a more widely available method to test s3 settings - #8158

Merged
rullzer merged 1 commit into
masterfrom
s3-minio
Feb 19, 2018
Merged

Use a more widely available method to test s3 settings#8158
rullzer merged 1 commit into
masterfrom
s3-minio

Conversation

@icewind1991

@icewind1991icewind1991 commented Feb 2, 2018

Copy link
Copy Markdown
Member

Fixes#8120

Bucket ACL's are not supported on minio making the test method always fail

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Feb 2, 2018
@icewind1991icewind1991 added this to the Nextcloud 14 milestone Feb 2, 2018
@icewind1991icewind1991 mentioned this pull request Feb 2, 2018
Closed
@codecov

codecovBot commented Feb 3, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8158 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #8158 +/- ##
============================================
+ Coverage 51.69% 51.69% +<.01% + Complexity 25389 25387 -2 
============================================
Files 1599 1599 Lines 95116 95114 -2 Branches 1376 1376 ============================================
Hits 49172 49172 + Misses 45944 45942 -2
Impacted FilesCoverage ΔComplexity Δ
apps/files_external/lib/Lib/Storage/AmazonS3.php0% <0%> (ø)108 <0> (-2)⬇️
lib/private/Security/CertificateManager.php91% <0%> (-1%)39% <0%> (ø)
lib/private/Server.php83.28% <0%> (+0.09%)282% <0%> (ø)⬇️

@icewind1991@rullzer
Use a more widely available method to test s3 settings
48ea714
Signed-off-by: Robin Appelman <robin@icewind.nl>
rullzer
rullzer approved these changes Feb 8, 2018
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

@morph027

morph027 commented Feb 19, 2018

Copy link
Copy Markdown

Works for us, thank you! 👍

@rullzer
rullzer merged commit 7ad1e13 into masterFeb 19, 2018
@rullzer
rullzer deleted the s3-minio branch February 19, 2018 16:09
@rullzerrullzer mentioned this pull request Mar 5, 2018
Merged
@jacksgt

jacksgt commented Mar 18, 2018

Copy link
Copy Markdown

Awesome, thanks for this!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@morph027@jacksgt@rullzer@MorrisJobke