Skip to content

Remove jquery ui background image - #8165

Merged
MorrisJobke merged 1 commit into
masterfrom
jquery-ui-missing-img
Feb 5, 2018
Merged

Remove jquery ui background image#8165
MorrisJobke merged 1 commit into
masterfrom
jquery-ui-missing-img

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

Remove leftover jquery ui background image, which was causing a request to a non-existing file:

GET http://localhost:8140/core/vendor/jquery-ui/themes/base/images/ui-bg_highlight-soft_75_cccccc_1x100.png 404 (Not Found)

Steps to reproduce:

  1. Upload a file so that the jquery ui progressbar comes up
  2. watch the browser console

@nextcloud/designers

@juliusknorrjuliusknorr added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Feb 3, 2018
@juliusknorrjuliusknorr added this to the Nextcloud 14 milestone Feb 3, 2018

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@rullzer
rullzerforce-pushed the jquery-ui-missing-img branch from 957976b to 36fd235CompareFebruary 3, 2018 21:10
@codecov

codecovBot commented Feb 3, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8165 into master will decrease coverage by 16.65%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #8165 +/- ##
=============================================
- Coverage 51.73% 35.08% -16.66% 
Complexity 25357 25357 =============================================
Files 1598 1598 Lines 95021 95021 Branches 1376 1376 =============================================
- Hits 49160 33336 -15824 - Misses 45861 61685 +15824
Impacted FilesCoverage ΔComplexity Δ
apps/files/lib/Activity/Settings/FileDeleted.php0% <0%> (-100%)8% <0%> (ø)
apps/user_ldap/lib/GroupPluginManager.php0% <0%> (-100%)17% <0%> (ø)
apps/files/lib/Activity/Settings/FileCreated.php0% <0%> (-100%)8% <0%> (ø)
lib/public/AppFramework/Http/DownloadResponse.php0% <0%> (-100%)1% <0%> (ø)
apps/files/lib/Activity/Settings/FileRestored.php0% <0%> (-100%)8% <0%> (ø)
lib/public/RichObjectStrings/Definitions.php0% <0%> (-100%)2% <0%> (ø)
apps/user_ldap/lib/UserPluginManager.php0% <0%> (-100%)24% <0%> (ø)
apps/files_trashbin/appinfo/app.php0% <0%> (-100%)0% <0%> (ø)
lib/private/App/AppStore/Version/Version.php0% <0%> (-100%)3% <0%> (ø)
apps/federation/lib/Hooks.php0% <0%> (-100%)4% <0%> (ø)
... and 516 more

@danxuliudanxuliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍; changes make sense to override the default background image from jQuery UI.

Failing tests are not related.

@MorrisJobke
MorrisJobke merged commit c592abe into masterFeb 5, 2018
@MorrisJobke
MorrisJobke deleted the jquery-ui-missing-img branch February 5, 2018 10:33
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

stable13: #8287

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr@rullzer@skjnldsv@danxuliu@MorrisJobke