Uh oh!
There was an error while loading. Please reload this page.
Remove jquery ui background image - #8165
Merged
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
rullzerforce-pushed
the
jquery-ui-missing-img
branch
from
February 3, 2018 21:10
957976b to
36fd235CompareCodecov Report
@@ Coverage Diff @@## master #8165 +/- ##
=============================================
- Coverage 51.73% 35.08% -16.66%
Complexity 25357 25357 =============================================
Files 1598 1598 Lines 95021 95021 Branches 1376 1376 =============================================
- Hits 49160 33336 -15824 - Misses 45861 61685 +15824
|
skjnldsv
approved these changes
Feb 4, 2018
danxuliu
approved these changes
Feb 4, 2018
danxuliu
left a comment
Member
There was a problem hiding this comment.
Tested and works 👍; changes make sense to override the default background image from jQuery UI.
Failing tests are not related.
juliusknorr
commented
Feb 9, 2018
MemberAuthor
stable13: #8287 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove leftover jquery ui background image, which was causing a request to a non-existing file:
Steps to reproduce:
@nextcloud/designers