Uh oh!
There was an error while loading. Please reload this page.
Fix "undefined index" problem - #8173
Merged
Merged
Conversation
Nextcloud 13RC4, error in logfile, triggered by "occ config:list": Invalid argument supplied for foreach() at lib/private/AppConfig.php#297 PHP Undefined index: workflowengine at lib/private/AppConfig.php#297 Fix: Check if index exists in array before using it.
nickvergessen
previously requested changes
Feb 4, 2018
| foreach ($this->sensitiveValues[$app] as $sensitiveKey) { | ||
| if (isset($values[$sensitiveKey])) { | ||
| $values[$sensitiveKey] = IConfig::SENSITIVE_VALUE; | ||
| if (array_key_exists($app, $this->sensitiveValues)) { |
using isset() instead of array_key_exists()
Codecov Report
@@ Coverage Diff @@## master #8173 +/- ##
============================================
- Coverage 51.73% 51.73% -0.01% - Complexity 25357 25358 +1
============================================
Files 1598 1598 Lines 95021 95022 +1 Branches 1376 1376 ============================================
- Hits 49159 49155 -4 - Misses 45862 45867 +5
|
MorrisJobke
approved these changes
Feb 5, 2018
nickvergessen
approved these changes
Feb 5, 2018
MorrisJobke
commented
Mar 6, 2018
Member
Backport is in #8693 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nextcloud 13RC4, error in logfile, triggered by
occ config:list:Fix: Check if index exists in array before using it.