Uh oh!
There was an error while loading. Please reload this page.
[stable 12] Do not try to get the jailed path if we can't find the id - #8196
Merged
Conversation
Fixes#8047 If we can't find the file by id there we should just return null instead of trying to get the jailed path of null. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
icewind1991
approved these changes
Feb 6, 2018
Codecov Report
@@ Coverage Diff @@## stable12 #8196 +/- ##
==============================================
+ Coverage 53.83% 53.84% +<.01% - Complexity 22761 22762 +1
==============================================
Files 1385 1385 Lines 87150 87152 +2 Branches 1331 1331 ==============================================
+ Hits 46920 46927 +7 + Misses 40230 40225 -5
|
MorrisJobke
approved these changes
Feb 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8160
Fixes#8047
If we can't find the file by id there we should just return null instead
of trying to get the jailed path of null.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl