Skip to content

keep previous exception when transforming to dav exception - #8224

Merged
icewind1991 merged 1 commit into
masterfrom
dav-dir-exception-previous
Feb 7, 2018
Merged

keep previous exception when transforming to dav exception#8224
icewind1991 merged 1 commit into
masterfrom
dav-dir-exception-previous

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Hopefully makes for easier debugging

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Feb 7, 2018
@icewind1991icewind1991 added this to the Nextcloud 14 milestone Feb 7, 2018
@rullzer

Copy link
Copy Markdown
Member

Yeah lets backport. So we have info when somebody runs into something.

@codecov

codecovBot commented Feb 7, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8224 into master will decrease coverage by 1.01%.
The diff coverage is 40%.

@@ Coverage Diff @@## master #8224 +/- ##
============================================
- Coverage 52.75% 51.73% -1.02% - Complexity 24062 25366 +1304 
============================================
Files 1506 1599 +93 Lines 90305 95064 +4759 Branches 1376 1376 ============================================
+ Hits 47643 49185 +1542 - Misses 42662 45879 +3217
Impacted FilesCoverage ΔComplexity Δ
apps/dav/lib/Connector/Sabre/Directory.php65.6% <0%> (ø)65 <0> (ø)⬇️
.../dav/lib/Connector/Sabre/Exception/InvalidPath.php81.81% <100%> (ø)3 <1> (ø)⬇️
lib/private/Server.php83.18% <0%> (-0.1%)282% <0%> (ø)
...pps/files_external/lib/Lib/DefinitionParameter.php83.01% <0%> (ø)23% <0%> (?)
apps/files_external/lib/Lib/IdentifierTrait.php63.63% <0%> (ø)8% <0%> (?)
apps/files_external/lib/Lib/DependencyTrait.php0% <0%> (ø)1% <0%> (?)
...iles_external/lib/Lib/Auth/OpenStack/Rackspace.php0% <0%> (ø)1% <0%> (?)
apps/files_external/lib/Lib/Backend/SFTP_Key.php0% <0%> (ø)1% <0%> (?)
...iles_external/lib/Lib/Auth/OpenStack/OpenStack.php0% <0%> (ø)1% <0%> (?)
...ernal/lib/Lib/Auth/Password/SessionCredentials.php42.85% <0%> (ø)4% <0%> (?)
... and 88 more

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@rullzer@nickvergessen