Uh oh!
There was an error while loading. Please reload this page.
[stable13] Better result handling of email search - #8267
Merged
Conversation
rullzer
requested review from
ChristophWurst, MorrisJobke, blizzz, danxuliu and nickvergessenFebruary 8, 2018 20:21
rullzer
commented
Feb 8, 2018
MemberAuthor
👍 from me |
MorrisJobke
commented
Feb 20, 2018
Member
CI fails. |
1. Local users should not be returned when searching for empty string 2. The limit of the response should be respected Signed-off-by: Joas Schilling <coding@schilljs.com>
Codecov Report
@@ Coverage Diff @@## stable13 #8267 +/- ##
==============================================
+ Coverage 51.22% 51.23% +<.01%
Complexity 24986 24986 ==============================================
Files 1608 1608 Lines 95089 95093 +4 Branches 1376 1376 ==============================================
+ Hits 48714 48721 +7 + Misses 46375 46372 -3
|
nickvergessen
commented
Feb 20, 2018
Member
Also fixed here |
blizzz
approved these changes
Feb 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8206
The limit of the response should be respected