Uh oh!
There was an error while loading. Please reload this page.
Show open graph preview in WhatsApp - #8308
Merged
Merged
Conversation
Whatsapp is picky about the size of the open graph images. So we do some special handling. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst, MorrisJobke, danxuliu, juliusknorr and nickvergessenFebruary 12, 2018 09:46
MorrisJobke
approved these changes
Feb 12, 2018
MorrisJobke
commented
Feb 12, 2018
Member
I would vote for a backport to stable13 ;) |
Codecov Report
@@ Coverage Diff @@## master #8308 +/- ##
============================================
- Coverage 51.76% 51.75% -0.01% - Complexity 25385 25386 +1
============================================
Files 1599 1599 Lines 95102 95109 +7 Branches 1376 1376 ============================================
- Hits 49227 49223 -4 - Misses 45875 45886 +11
|
nickvergessen
approved these changes
Feb 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whatsapp is picky about the size of the open graph images.
So we do some special handling.
Now:
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl