Uh oh!
There was an error while loading. Please reload this page.
Use mb_* string methods to extract first character for generated avatars - #8468
Merged
Conversation
This fixes#8451 where the first character is a non-ASCII character. The `$string[0]` notation only extracted one byte and thus resulting in an invalid code. The `mb_strtoupper` method also allows to convert characters independently from the current locale on the server. See also http://php.net/manual/en/function.mb-strtoupper.php Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
blizzz, juliusknorr, nickvergessen and rullzerFebruary 21, 2018 09:37
Codecov Report
@@ Coverage Diff @@## master #8468 +/- ##
=========================================
Coverage 51.82% 51.82% Complexity 25363 25363 =========================================
Files 1601 1601 Lines 95018 95018 Branches 1377 1377 =========================================
Hits 49241 49241 Misses 45777 45777
|
nickvergessen
approved these changes
Feb 21, 2018
juliusknorr
approved these changes
Feb 21, 2018
rullzer
approved these changes
Feb 21, 2018
MorrisJobke
commented
Feb 21, 2018
MemberAuthor
Stable12 not needed because it is done in JS there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes#8451 where the first character is a non-ASCII character. The
$string[0]notation only extracted one byte and thus resulting in an invalid code. Themb_strtouppermethod also allows to convert characters independently from the current locale on the server.See also http://php.net/manual/en/function.mb-strtoupper.php
I would also backport this to 13 and 12 to prevent further reports on this.