Skip to content

Provide translated error message for permission error - #8541

Merged
MorrisJobke merged 1 commit into
masterfrom
translate-permission-error-page
Feb 26, 2018
Merged

Provide translated error message for permission error#8541
MorrisJobke merged 1 commit into
masterfrom
translate-permission-error-page

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Found while reviewing #8511

Just go to http://example.org/settings/admin/externalstorages as normal user and check the error message

bildschirmfoto 2018-02-26 um 15 32 48

This text is now properly localised.

@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. labels Feb 26, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 14 milestone Feb 26, 2018

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@juliusknorr

Copy link
Copy Markdown
Member

Tests are failing 😉

@MorrisJobke
MorrisJobkeforce-pushed the translate-permission-error-page branch from d678487 to e298927CompareFebruary 26, 2018 15:27
@codecov

codecovBot commented Feb 26, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8541 into master will decrease coverage by 45.19%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #8541 +/- ##
===========================================
- Coverage 51.82% 6.62% -45.2% 
Complexity 25379 25379 ===========================================
Files 1601 1601 Lines 95065 95070 +5 Branches 1379 1379 ===========================================
- Hits 49265 6297 -42968 - Misses 45800 88773 +42973
Impacted FilesCoverage ΔComplexity Δ
...ddleware/Security/Exceptions/NotAdminException.php0% <0%> (-100%)1 <1> (ø)
settings/Middleware/SubadminMiddleware.php0% <0%> (-92.86%)6 <0> (ø)
...amework/Middleware/Security/SecurityMiddleware.php0% <0%> (-78.05%)26 <0> (ø)
...e/AppFramework/DependencyInjection/DIContainer.php0% <0%> (-82.73%)54 <0> (ø)
apps/comments/lib/JSSettingsHelper.php0% <0%> (-100%)2% <0%> (ø)
apps/files_trashbin/lib/AppInfo/Application.php0% <0%> (-100%)2% <0%> (ø)
core/Command/TwoFactorAuth/Enable.php0% <0%> (-100%)4% <0%> (ø)
apps/dav/lib/CalDAV/Activity/Filter/Calendar.php0% <0%> (-100%)7% <0%> (ø)
lib/private/Comments/ManagerFactory.php0% <0%> (-100%)2% <0%> (ø)
settings/Activity/SecuritySetting.php0% <0%> (-100%)8% <0%> (ø)
... and 864 more

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Tests are failing 😉

🙈 Too stupid to fix the unit tests properly (added the new dependency 3 lines too low xD)

@rullzerrullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 26, 2018
@MorrisJobke
MorrisJobkeforce-pushed the translate-permission-error-page branch from e298927 to 537fbdcCompareFebruary 26, 2018 15:30
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
MorrisJobkeforce-pushed the translate-permission-error-page branch from 537fbdc to cf35c4bCompareFebruary 26, 2018 16:00
@MorrisJobke
MorrisJobke merged commit a60d7a8 into masterFeb 26, 2018
@MorrisJobke
MorrisJobke deleted the translate-permission-error-page branch February 26, 2018 16:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishpapercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@juliusknorr@rullzer@skjnldsv