Skip to content

Fixed app navigation for IE11 - #8573

Merged
rullzer merged 2 commits into
masterfrom
appnav-ie11-fixes
Mar 1, 2018
Merged

Fixed app navigation for IE11#8573
rullzer merged 2 commits into
masterfrom
appnav-ie11-fixes

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Feb 28, 2018

Copy link
Copy Markdown
Member

Fixesnextcloud/calendar#742
Fixes https://help.nextcloud.com/t/bug-help-the-latest-updates-to-contacts-only-spins/27521/

See https://caniuse.com/#feat=flexbox

IE 11 requires a unit to be added to the third argument, the flex-basis property see MSFT documentation

@nextcloud/designers

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@codecov

codecovBot commented Feb 28, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8573 into master will decrease coverage by 45.3%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #8573 +/- ##
============================================
- Coverage 51.9% 6.6% -45.31% 
Complexity 25434 25434 ============================================
Files 1609 1609 Lines 95365 95365 Branches 1378 1378 ============================================
- Hits 49502 6300 -43202 - Misses 45863 89065 +43202
Impacted FilesCoverage ΔComplexity Δ
lib/private/DB/QueryBuilder/Parameter.php0% <0%> (-100%)2% <0%> (ø)
...te/Authentication/Token/DefaultTokenCleanupJob.php0% <0%> (-100%)1% <0%> (ø)
apps/files_versions/lib/AppInfo/Application.php0% <0%> (-100%)2% <0%> (ø)
apps/dav/lib/CalDAV/PublicCalendarObject.php0% <0%> (-100%)1% <0%> (ø)
lib/private/Group/Database.php0% <0%> (-100%)26% <0%> (ø)
lib/private/Hooks/LegacyEmitter.php0% <0%> (-100%)1% <0%> (ø)
...pFramework/Db/MultipleObjectsReturnedException.php0% <0%> (-100%)1% <0%> (ø)
apps/dav/lib/CalDAV/Activity/Setting/Calendar.php0% <0%> (-100%)8% <0%> (ø)
apps/files/lib/Activity/Settings/FileCreated.php0% <0%> (-100%)8% <0%> (ø)
lib/private/Session/Session.php0% <0%> (-100%)5% <0%> (ø)
... and 867 more

@pixelipo
pixelipo removed their request for review February 28, 2018 10:13
@skjnldsvskjnldsv added the 3. to review Waiting for reviews label Feb 28, 2018

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in IE11 and works 👍

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

One more review?

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 1, 2018
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Failure also unrelated

@rullzer
rullzer merged commit d70a35b into masterMar 1, 2018
@rullzer
rullzer deleted the appnav-ie11-fixes branch March 1, 2018 19:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishdesignDesign, UI, UX, etc.highregression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@MorrisJobke@juliusknorr@rullzer