Uh oh!
There was an error while loading. Please reload this page.
[stable12] Fix comments (and systemtags) when involving users with numerical ids - #8616
Merged
Conversation
test creating comments with numeric user ids Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> fix creating comments when file is accessible to users with numeric ids Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> tests for systemtags related to numeric user ids Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> fix systemtags event with numeric user ids Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
ChristophWurst, MorrisJobke, nickvergessen and rullzerMarch 1, 2018 23:34
2 tasks
rullzer
approved these changes
Mar 2, 2018
Codecov Report
@@ Coverage Diff @@## stable12 #8616 +/- ##
==============================================
+ Coverage 53.84% 53.92% +0.08% - Complexity 22762 22764 +2
==============================================
Files 1386 1387 +1 Lines 87154 87251 +97 Branches 1331 1331 ==============================================
+ Hits 46930 47053 +123 + Misses 40224 40198 -26
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #8355 to stable12