[12] Properly encapsulate require_once for app.php

[juliusknorr]

If an app has an appinfo/app.php file, that includes a variable called $app, this would lead to a type error when calling getAppInfo otherwise.

Backport of #8372

[codecov]

Codecov Report

Merging #8632 into stable12 will increase coverage by <.01%.
The diff coverage is 33.33%.

@@ Coverage Diff @@## stable12 #8632 +/- ##
==============================================
+ Coverage 53.92% 53.92% +<.01% 
Complexity 22764 22764 ==============================================
Files 1387 1387 Lines 87251 87251 Branches 1331 1331 ==============================================
+ Hits 47050 47051 +1 + Misses 40201 40200 -1

Impacted Files	Coverage Δ	Complexity Δ
lib/private/legacy/app.php	52.8% <33.33%> (ø)	219 <0> (ø)	⬇️
lib/private/Server.php	84.68% <0%> (-0.13%)	121% <0%> (ø)
core/js/js.js	61.94% <0%> (+0.11%)	0% <0%> (ø)	⬇️
lib/private/Security/CertificateManager.php	92.07% <0%> (+0.99%)	39% <0%> (ø)	⬇️

[nickvergessen]

Is this still true?

[MorrisJobke]

Yes. This is another exception outside of this try catch.