Skip to content

Fixed date/time picker on IE11 - #8650

Merged
MorrisJobke merged 1 commit into
masterfrom
fix-ie11-datepicker-display
Mar 5, 2018
Merged

Fixed date/time picker on IE11#8650
MorrisJobke merged 1 commit into
masterfrom
fix-ie11-datepicker-display

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Mar 5, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Fix#8484 @nextcloud/designers @jpimlott

BeforeAfter
virtualbox_ie11 - win7_01_03_2018_21_36_03virtualbox_ie11 - win7_01_03_2018_21_36_05
virtualbox_ie11 - win7_01_03_2018_21_42_56virtualbox_ie11 - win7_01_03_2018_21_35_52

@skjnldsv
Fixed date/time picker on IE11
31c7fcd
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews medium regression labels Mar 5, 2018
@skjnldsvskjnldsv added this to the Nextcloud 14 milestone Mar 5, 2018
@skjnldsvskjnldsv self-assigned this Mar 5, 2018
@pixelipo
pixelipo removed their request for review March 5, 2018 11:06
@pixelipo

pixelipo commented Mar 5, 2018

Copy link
Copy Markdown
Contributor

Sorry @skjnldsv - I'm not able to test on IE11. Code looks ok, though

@codecov

codecovBot commented Mar 5, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8650 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #8650 +/- ##
============================================
- Coverage 51.87% 51.87% -0.01% 
Complexity 25351 25351 ============================================
Files 1606 1606 Lines 95066 95066 Branches 1378 1378 ============================================
- Hits 49316 49315 -1 - Misses 45750 45751 +1
Impacted FilesCoverage ΔComplexity Δ
lib/private/Security/CertificateManager.php91% <0%> (-3%)39% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.46% <0%> (-0.25%)136% <0%> (ø)
lib/private/Server.php83.1% <0%> (+0.09%)282% <0%> (ø)⬇️
lib/private/Files/ObjectStore/SwiftFactory.php56.32% <0%> (+2.29%)35% <0%> (ø)⬇️

MorrisJobke
MorrisJobke approved these changes Mar 5, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works 👍

@MorrisJobke
MorrisJobke merged commit f72e9ae into masterMar 5, 2018
@MorrisJobke
MorrisJobke deleted the fix-ie11-datepicker-display branch March 5, 2018 15:38
@MorrisJobke

MorrisJobke commented Mar 5, 2018

Copy link
Copy Markdown
Member

@skjnldsv Could you open a Backport PR?

@skjnldsv

skjnldsv commented Mar 5, 2018

Copy link
Copy Markdown
MemberAuthor

Of course!

@skjnldsvskjnldsv mentioned this pull request Mar 5, 2018
Merged
@skjnldsv

skjnldsv commented Mar 5, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Backport in #8663

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.mediumregression

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@pixelipo@MorrisJobke@rullzer