Skip to content

[stable13] generate different UIDs for Birthday, Anniversary and Death event - #8678

Merged
MorrisJobke merged 1 commit into
stable13from
7707_13
Mar 6, 2018
Merged

[stable13] generate different UIDs for Birthday, Anniversary and Death event#8678
MorrisJobke merged 1 commit into
stable13from
7707_13

Conversation

@rullzer

@rullzerrullzer commented Mar 6, 2018

Copy link
Copy Markdown
Member

Backport of #7707

@georgehrke@rullzer
generate different UIDs for Birthday, Anniversary and Death event
6171940
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@rullzerrullzer added the 3. to review Waiting for reviews label Mar 6, 2018
@rullzerrullzer added this to the Nextcloud 13.0.1 milestone Mar 6, 2018
@codecov

codecovBot commented Mar 6, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8678 into stable13 will decrease coverage by 0.17%.
The diff coverage is 100%.

@@ Coverage Diff @@## stable13 #8678 +/- ##
==============================================
- Coverage 51.3% 51.12% -0.18% - Complexity 24998 25088 +90 
==============================================
Files 1609 1609 Lines 95236 95568 +332 Branches 1376 1376 ==============================================
- Hits 48858 48857 -1 - Misses 46378 46711 +333
Impacted FilesCoverage ΔComplexity Δ
apps/dav/lib/CalDAV/BirthdayService.php81.29% <100%> (ø)44 <12> (ø)⬇️
apps/user_ldap/lib/Access.php25.32% <0%> (-10.3%)406% <0%> (+90%)
apps/files_trashbin/lib/Trashbin.php72.28% <0%> (-0.25%)136% <0%> (ø)

@MorrisJobke
MorrisJobke merged commit 16fa18a into stable13Mar 6, 2018
@MorrisJobke
MorrisJobke deleted the 7707_13 branch March 6, 2018 12:37
@MorrisJobkeMorrisJobke mentioned this pull request Mar 9, 2018
Merged
10 tasks
@georgehrkegeorgehrke mentioned this pull request May 1, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@georgehrkegeorgehrkeAwaiting requested review from georgehrke
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 13.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@MorrisJobke@ChristophWurst@georgehrke