Skip to content

[Part2] Make thunderbird and outlook addons identifyable - #8690

Merged
rullzer merged 2 commits into
masterfrom
feature/8565/make-thunderbird-and-outlook-addons-identifyable
Aug 9, 2018
Merged

[Part2] Make thunderbird and outlook addons identifyable#8690
rullzer merged 2 commits into
masterfrom
feature/8565/make-thunderbird-and-outlook-addons-identifyable

Conversation

@nickvergessen

@nickvergessennickvergessen commented Mar 6, 2018

Copy link
Copy Markdown
Member

part 2 of too early merged #8565 (if back ported it should be back ported together with that fix)

Let's wait with merging for confirmation by:

@nickvergessennickvergessen added this to the Nextcloud 14 milestone Mar 6, 2018
@nickvergessennickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 6, 2018
@codecov

codecovBot commented Mar 6, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8690 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #8690 +/- ##
============================================
- Coverage 51.9% 51.87% -0.03% + Complexity 25365 25354 -11 
============================================
Files 1607 1606 -1 Lines 95326 95077 -249 Branches 1394 1378 -16 ============================================
- Hits 49481 49324 -157 + Misses 45845 45753 -92
Impacted FilesCoverage ΔComplexity Δ
...are/Security/Exceptions/AppNotEnabledException.php0% <0%> (-100%)1% <0%> (ø)
...aring/lib/Controller/MountPublicLinkController.php21.52% <0%> (-20.37%)24% <0%> (+10%)
...B/QueryBuilder/FunctionBuilder/FunctionBuilder.php61.53% <0%> (-16.24%)6% <0%> (-3%)
lib/public/Util.php44.28% <0%> (-15.91%)59% <0%> (+14%)
lib/private/Route/Route.php26.08% <0%> (-15.22%)14% <0%> (ø)
core/js/sharedialogview.js75.43% <0%> (-12.11%)0% <0%> (ø)
lib/private/User/Database.php68.99% <0%> (-10.07%)45% <0%> (+3%)
lib/private/Mail/Message.php79.16% <0%> (-6.36%)24% <0%> (-5%)
lib/private/legacy/app.php57.89% <0%> (-4.75%)198% <0%> (+2%)
lib/public/Share.php35.29% <0%> (-4.71%)7% <0%> (+1%)
... and 172 more

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the feature/8565/make-thunderbird-and-outlook-addons-identifyable branch from 5a24f17 to 1fbfe7bCompareApril 19, 2018 08:32
@MorrisJobkeMorrisJobke added the stale Ticket or PR with no recent activity label Jun 19, 2018
@MorrisJobke

Copy link
Copy Markdown
Member

Nothing for 14 it seems -> moved to 15

@nextcloud-botnextcloud-bot removed the stale Ticket or PR with no recent activity label Jun 29, 2018
@rullzer

Copy link
Copy Markdown
Member

@nickvergessen so merge this for 14 is the plan right? Then the outlook plugin (and soonish maybe the filelink thunderbird thingy) can be used as well there.

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

yes

@rullzerrullzer modified the milestones: Nextcloud 15, Nextcloud 14Aug 9, 2018
@rullzerrullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 9, 2018
@rullzerrullzer mentioned this pull request Aug 9, 2018
58 tasks

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🐘

@rullzer
rullzer merged commit a21c93a into masterAug 9, 2018
@rullzer
rullzer deleted the feature/8565/make-thunderbird-and-outlook-addons-identifyable branch August 9, 2018 07:55
@MorrisJobke

Copy link
Copy Markdown
Member

@nickvergessen@rullzer I guess we don't backport this, right?

@MorrisJobkeMorrisJobke mentioned this pull request Aug 22, 2018
8 tasks
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Fine by me

@MorrisJobke

Copy link
Copy Markdown
Member

Fine by me

Let's do it for 13.0.7

@MorrisJobke

Copy link
Copy Markdown
Member

Let's not backport it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen@MorrisJobke@rullzer@ChristophWurst@nextcloud-bot