Uh oh!
There was an error while loading. Please reload this page.
Tests for email collaborators pagination - #8710
Merged
Merged
Conversation
| } | ||
| $searchResult->addResultSet($emailType, $result['wide'], $result['exact']); | ||
| return true; |
MemberAuthor
There was a problem hiding this comment.
this was a pretty bad assumption, so I had to fix all tests and wrote some where it is actually supposed to be true
Member
There was a problem hiding this comment.
Its the default for anything that cannot (or could not) paginate. I took it over as it was when i refactored it.
blizzz
commented
Mar 7, 2018
Member
no test case where you look for $reachedEnd = true? |
| $result['wide'] = []; | ||
| $userResults['wide'] = []; | ||
| } else { | ||
| $reachedEnd = (count($result['wide']) < $offset + $limit) || |
Member
There was a problem hiding this comment.
Isn't the end reached when both sets don't have further elements?
MemberAuthor
There was a problem hiding this comment.
yeah should have been &&
also the answer for @blizzz comment. I messed up when inverting the logic from "more results" to "end reached"
nickvergessenforce-pushed
the
followup/8596/tests-for-user-pagination
branch
from
March 7, 2018 11:12
db8d664 to
d03663cCompareblizzz
commented
Mar 8, 2018
Member
failing tests |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
followup/8596/tests-for-user-pagination
branch
from
March 8, 2018 12:26
d03663c to
fe30d63CompareCodecov Report
@@ Coverage Diff @@## master #8710 +/- ##
=============================================
- Coverage 51.86% 34.98% -16.89% - Complexity 25373 25374 +1
=============================================
Files 1607 1607 Lines 95170 95173 +3 Branches 1379 1379 =============================================
- Hits 49362 33297 -16065 - Misses 45808 61876 +16068
|
nickvergessen
commented
Mar 8, 2018
MemberAuthor
I messed up conflict resolution on rebase. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
followup/8596/tests-for-user-pagination
branch
from
March 8, 2018 15:22
fe30d63 to
8820966Comparerullzer
approved these changes
Mar 8, 2018
nickvergessen
commented
Mar 9, 2018
MemberAuthor
Backport in #8749 |
blizzz
approved these changes
Mar 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #8596