Skip to content

disable part files for object stores - #8715

Merged
rullzer merged 2 commits into
masterfrom
objectstore-no-part-files
Mar 8, 2018
Merged

disable part files for object stores#8715
rullzer merged 2 commits into
masterfrom
objectstore-no-part-files

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Renaming the part file to the target file while preserving fileids can't be done for object stores without issues.

To test

  • upload a new file to s3 object store
  • check the fileid
  • overwrite the file with dav upload
  • check the fileid again

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added this to the Nextcloud 14 milestone Mar 7, 2018

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs more work.

If I checkout this branch we directly create a new version on upload.

Signed-off-by: Robin Appelman <robin@icewind.nl>
@codecov

codecovBot commented Mar 8, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8715 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #8715 +/- ##
===========================================
- Coverage 51.87% 51.8% -0.08% - Complexity 25367 25368 +1 
===========================================
Files 1607 1607 Lines 95154 95156 +2 Branches 1379 1379 ===========================================
- Hits 49362 49294 -68 - Misses 45792 45862 +70
Impacted FilesCoverage ΔComplexity Δ
...b/private/Files/ObjectStore/ObjectStoreStorage.php66.66% <0%> (-0.57%)75 <1> (+1)
lib/private/Files/ObjectStore/Swift.php0% <0%> (-75%)8% <0%> (ø)
lib/private/Files/ObjectStore/SwiftFactory.php0% <0%> (-56.33%)35% <0%> (ø)
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)

@icewind1991

Copy link
Copy Markdown
MemberAuthor

@rullzer fixed

(this probably also was an issue when using s2s sharing)

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the trick!

@rullzer
rullzer merged commit d054699 into masterMar 8, 2018
@rullzer
rullzer deleted the objectstore-no-part-files branch March 8, 2018 19:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@rullzer@MorrisJobke