Skip to content

[stable13] Fix integer overflow in ChunkingPlugin - #8752

Merged
MorrisJobke merged 1 commit into
stable13from
13-8112
Mar 9, 2018
Merged

[stable13] Fix integer overflow in ChunkingPlugin#8752
MorrisJobke merged 1 commit into
stable13from
13-8112

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Avoids errors when the size exceeds MAX_INT because of the cast to int. Better cast it to float to avoid this.

Backport of #8112

Avoids errors when the size exceeds MAX_INT because of the cast to int. Better cast it to float to avoid this.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Mar 9, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 13.0.1 milestone Mar 9, 2018
This was referenced Mar 9, 2018

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same code as in master

@codecov

codecovBot commented Mar 9, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8752 into stable13 will decrease coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## stable13 #8752 +/- ##
==============================================
- Coverage 51.3% 51.29% -0.01% - Complexity 25017 25020 +3 
==============================================
Files 1609 1609 Lines 95285 95288 +3 Branches 1376 1376 ==============================================
Hits 48882 48882 - Misses 46403 46406 +3
Impacted FilesCoverage ΔComplexity Δ
apps/dav/lib/Upload/ChunkingPlugin.php96.29% <100%> (ø)8 <0> (ø)⬇️
lib/private/Template/JSCombiner.php87.5% <0%> (-1.61%)31% <0%> (+1%)
...b/private/Files/ObjectStore/ObjectStoreStorage.php66.39% <0%> (-0.56%)75% <0%> (+1%)
apps/dav/lib/Connector/Sabre/File.php74.04% <0%> (+0.18%)102% <0%> (+1%)⬆️

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Also 👍 from me, because I only did a straight cherry-pick

@MorrisJobke
MorrisJobke merged commit 0f1567d into stable13Mar 9, 2018
@MorrisJobke
MorrisJobke deleted the 13-8112 branch March 9, 2018 10:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@MorrisJobke@nickvergessen