Skip to content

[stable13] Show group display names - #8779

Merged
skjnldsv merged 5 commits into
stable13from
backport/8255/show-group-display-names
Apr 6, 2018
Merged

[stable13] Show group display names#8779
skjnldsv merged 5 commits into
stable13from
backport/8255/show-group-display-names

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Only backporting the user facing easy stuff from #8255

nickvergessenand others added 4 commits March 12, 2018 12:00
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@blizzz

Copy link
Copy Markdown
Member

CI is unhappy

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the backport/8255/show-group-display-names branch from b9926ec to 5e15c76CompareMarch 16, 2018 09:50
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

fixed

@codecov

codecovBot commented Mar 16, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8779 into stable13 will decrease coverage by 0.02%.
The diff coverage is 45.83%.

@@ Coverage Diff @@## stable13 #8779 +/- ##
==============================================
- Coverage 51.33% 51.31% -0.03% - Complexity 25022 25038 +16 
==============================================
Files 1609 1609 Lines 95290 95530 +240 Branches 1376 1376 ==============================================
+ Hits 48919 49017 +98 - Misses 46371 46513 +142
Impacted FilesCoverage ΔComplexity Δ
lib/private/Settings/Personal/PersonalInfo.php0% <0%> (ø)29 <0> (ø)⬇️
apps/dav/lib/CalDAV/Activity/Provider/Event.php0% <0%> (ø)25 <1> (ø)⬇️
apps/dav/lib/CalDAV/Activity/Provider/Calendar.php0% <0%> (ø)65 <1> (ø)⬇️
...ps/files_sharing/lib/Activity/Providers/Groups.php0% <0%> (ø)22 <5> (+5)⬆️
lib/private/Group/MetaData.php68.91% <100%> (ø)19 <0> (ø)⬇️
settings/Controller/GroupsController.php68.33% <100%> (+3.71%)9 <0> (ø)⬇️
apps/dav/lib/CalDAV/Activity/Provider/Base.php79.36% <85%> (+2.57%)19 <7> (+3)⬆️
lib/private/Server.php80.55% <0%> (-0.12%)134% <0%> (ø)
apps/user_ldap/lib/Access.php36.92% <0%> (+0.73%)327% <0%> (+8%)⬆️
lib/private/Security/CertificateManager.php92.07% <0%> (+0.99%)39% <0%> (ø)⬇️
... and 1 more

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

@skjnldsv
skjnldsv merged commit d45a889 into stable13Apr 6, 2018
@skjnldsv
skjnldsv deleted the backport/8255/show-group-display-names branch April 6, 2018 13:14
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 6, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Apr 18, 2018
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: activity and notification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@blizzz@rullzer@skjnldsv